Add Husky and lint-staged for better codestyle checks on commit #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, we need this! 👍 |
rick-nu
previously requested changes
Jul 15, 2019
|
Took care of the old git-hooks, they are gonez0r now! |
rick-nu
reviewed
Jul 24, 2019
|
Works like a charm! 👍 Nice! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add Husky and lint-staged
Why
This makes it much more seamless to only commit correctly styled javascript. Before this PR files would be cleaned but not staged so files with broken codestyle would still be committed.